Remove unnecessary monkey patching #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloh
force-pushed
the
remove_time_money_patch
branch
from
e52323f to
4d8782a
Compare
hsbt
added a commit
that referenced
this pull request
Oct 9, 2015
Remove unnecessary monkey patching
|
It seems good because travis-ci is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of monkey patching isn't really necessary since
Time#<=>is smart enough to try inverting the operands if the argument it receives is not an instance of Time.Also the alias chain can be a source of headaches if you want to use it simultaneously with the new method
Module#prepend: rails/rails#19878