Implement support for collection serializers. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| serializer_class = resource_defined_class | ||
| serializer_class ||= collection_class | ||
| serializer_class ||= options[:serializer] | ||
| @serializer_class ||= ( |
There was a problem hiding this comment.
Is this even valid Ruby? ;)
I think it should be
serializer_class ||= begin
...
endThere was a problem hiding this comment.
Even better:
return if @serializer_class
@serialiazer_class = resource_defined_class
@serialiazer_class ||= collection_class
@serialiazer_class ...
|
Needs CHANGELOG too I believe. I am afraid I don't know more about your question ;( |
drn
force-pushed
the
collection-serializer-support
branch
from
48505eb to
af3ccab
Compare
|
@dblock - Thanks for the comments! I've addressed them, updated the changelog with whatever pulls were missing, and updated the pull. |
Closed
| end | ||
|
|
||
| private | ||
|
|
||
| attr_accessor :resource, :options | ||
|
|
||
| def serializer_class | ||
| return @serializer_class if defined?(@serializer_class) | ||
| serializer_class = resource_defined_class |
There was a problem hiding this comment.
Why don't you just use @serializer_class?
There was a problem hiding this comment.
good call, ill switch to that
|
More questions, but this is very close to merging. |
drn
force-pushed
the
collection-serializer-support
branch
from
af3ccab to
6bb2057
Compare
|
@dblock - Updated addressing your comments! Thanks again |
|
Merged, thanks for hanging in here! |
|
Cool, no prob. Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implements support for
namespaceandversionserializer resolution in collection serializers.@dblock if you have any knowledge of how asm handles the each_serializer option, that would be great info, but using the serializer option is the only way I've gotten it to work. I tried passing the each_serializer options around as both an adapter and a serializer option, but have run into issues with both.