Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveModel::Serializer.serializer_for(resource, ams_options))
called even ifoptions[:serializer]
exists. This causes some strange behavior.Here is example.
Lets assume we have model
User
and serializerUserSerializer
in module V1 (model is in no module, serializer is inserializers/v1/user_serializer.rb
file).And we have simple api for user:
In that case, Grape-AMS will trying to load
UserSerializer
(on the assumption of model name). AMS can find fileuser_serializer.rb
, but he can't get constUserSerializer
in this file, because in this file we haveV1::UserSerializer
const, so we get error'Unable to autoload constant UserSerializer, expected /.../serializers/v1/user_serializer.rb to define it'
.But we already specified that we want
V1::UserSerializer
.If we specify some other serializer,
V1::OtherSerializer
or justWithoutModuleSerializer
, we will get this error again.