Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #106] Make Rails/ReflectionClassName aware of the use of string with to_s #471

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 28, 2021

Follow #469

Fixes #106.

This PR makes Rails/ReflectionClassName aware of the use of string with to_s.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…f string with `to_s`

Follow rubocop#469

Fixes rubocop#106.

This PR makes `Rails/ReflectionClassName` aware of the use of string with `to_s`.
@koic koic force-pushed the make_rails_reflection_class_name_aware_of_to_s branch from c63188f to 1d6317b Compare April 28, 2021 15:20
@koic koic merged commit bc2319f into rubocop:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/ReflectionClassName gives false positive
1 participant