[Fix #106] Mark Rails/ReflectionClassName as unsafe
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#106. This PR marks `Rails/ReflectionClassName` as unsafe. And it would be possible to exclude `to_s` call other than constants. I will consider opening it as a separate PR.
koic
force-pushed
the
mark_rails_reflection_class_name_as_unsafe
branch
from
a2996f8 to
c9d6e7e
Compare
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 28, 2021
…f string with `to_s` Follow rubocop#469 Fixes rubocop#106. This PR makes `Rails/ReflectionClassName` aware of the use of string with `to_s`.
9 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 28, 2021
…f string with `to_s` Follow rubocop#469 Fixes rubocop#106. This PR makes `Rails/ReflectionClassName` aware of the use of string with `to_s`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106.
This PR marks
Rails/ReflectionClassNameas unsafe.And it would be possible to exclude
to_scall other than constants. I will consider opening it as a separate PR.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.