[Fix #144] false positive for Rails/ReversibleMigration
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Below is a similar PR under review. I think it needs to be checked that |
change_table_comment is only irreversible when passing a string as the comment. If we pass a hash with `:from` and `:to` keys, it works as a reversible migration Fixes rubocop#144
koic
reviewed
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144
I've made this commit based on
change_column_defaultlogic, so I'm not sure if the pattern is the best one.I've also thought about grouping the checks from
change_column_default,change_table_commentandchange_column_commentinto a more generic check that looks if a method has a hash with:from/:tokeys, but I'm not sure if it's the best approach. Let me know which way is better :)Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.