-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails/ReversibleMigration - False positive with change_table_comment #144
Labels
bug
Something isn't working
Comments
DNA
added a commit
to DNA/rubocop-rails
that referenced
this issue
Oct 31, 2019
change_table_comment is onli irreversible when passing a string as the comment. If we pass a hash with `:from` and `:to`, it works as a reversible migration Fixes rubocop#144
DNA
added a commit
to DNA/rubocop-rails
that referenced
this issue
Oct 31, 2019
change_table_comment is only irreversible when passing a string as the comment. If we pass a hash with `:from` and `:to` keys, it works as a reversible migration Fixes rubocop#144
8 tasks
DNA
added a commit
to DNA/rubocop-rails
that referenced
this issue
Oct 31, 2019
change_table_comment is only irreversible when passing a string as the comment. If we pass a hash with `:from` and `:to` keys, it works as a reversible migration Fixes rubocop#144
DNA
added a commit
to DNA/rubocop-rails
that referenced
this issue
Nov 4, 2019
change_table_comment is only irreversible when passing a string as the comment. If we pass a hash with `:from` and `:to` keys, it works as a reversible migration Fixes rubocop#144
DNA
added a commit
to DNA/rubocop-rails
that referenced
this issue
Nov 4, 2019
change_table_comment is only irreversible when passing a string as the comment. If we pass a hash with `:from` and `:to` keys, it works as a reversible migration Fixes rubocop#144
koic
added a commit
that referenced
this issue
Nov 11, 2019
[Fix #144] false positive for `Rails/ReversibleMigration`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rails/ReversibleMigration
cop throw an offense even when the methodchange_table_comment
pass a hash with:from
and:to
Expected behavior
Only throw an offense if it's not a hash with
:from
and:to
Actual behavior
Steps to reproduce the problem
Just create a migration with change_table_comment
RuboCop version
The text was updated successfully, but these errors were encountered: