Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Rails/EnumHash #142

Merged

Conversation

koic
Copy link
Member

@koic koic commented Oct 21, 2019

Closes #114.

This PR fixes an incorrect autocorrect for Rails/EnumHash when using nested constants.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Closes rubocop#114.

This PR fixes an incorrect autocorrect for `Rails/EnumHash`
when using nested constants.
@koic koic force-pushed the fix_an_incorrect_autocorrect_for_rails_enum_hash branch from fc21289 to e877a13 Compare October 21, 2019 05:09
@koic koic merged commit 109dcdd into rubocop:master Oct 21, 2019
@koic koic deleted the fix_an_incorrect_autocorrect_for_rails_enum_hash branch October 21, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant