Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnumHash breaks on nested constants #114

Closed
wants to merge 1 commit into from

Conversation

mlarraz
Copy link

@mlarraz mlarraz commented Aug 21, 2019

The test case below should pass, but instead fails with:

-enum status: {STATUS::OLD=>0, STATUS::ACTIVE=>1}
+enum status: {s(:const, nil, :STATUS)=>1}

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
Copy link
Member

koic commented Oct 13, 2019

Thanks for the feedback issue. Could you open the issue instead of the PR if the product code is not likely to be added recently?

koic added a commit to koic/rubocop-rails that referenced this pull request Oct 21, 2019
Closes rubocop#114.

This PR fixes an incorrect autocorrect for `Rails/EnumHash`
when using nested constants.
koic added a commit to koic/rubocop-rails that referenced this pull request Oct 21, 2019
Closes rubocop#114.

This PR fixes an incorrect autocorrect for `Rails/EnumHash`
when using nested constants.
@koic koic closed this in #142 Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants