Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation #383

Closed
wants to merge 1 commit into from
Closed

Improve documentation #383

wants to merge 1 commit into from

Conversation

pyhys
Copy link
Collaborator

@pyhys pyhys commented Mar 17, 2021 •
edited
Loading

Split Codesys page into two pages

Improve logging
Improve error message display in sample app.

@pyhys pyhys requested a review from olbjo March 17, 2021 17:49
@pyhys pyhys mentioned this pull request Mar 18, 2021
Merged
olbjo
olbjo approved these changes Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@olbjo olbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
I did a quick review of all files except for the alarm updates which are also part of another PR.

@pyhys pyhys force-pushed the improve_documentation_week09 branch from 7b7b94c to 52e6136 Compare March 24, 2021 08:32
@pyhys pyhys requested a review from hefloryd March 24, 2021 08:35
@pyhys pyhys mentioned this pull request Mar 24, 2021
Merged
@pyhys pyhys force-pushed the improve_documentation_week09 branch 4 times, most recently from 13239e2 to 4e6f1eb Compare March 29, 2021 05:20
@pyhys
Copy link
Collaborator Author

pyhys commented Mar 29, 2021

Rebased on master

@pyhys pyhys force-pushed the improve_documentation_week09 branch from 4e6f1eb to ea968ef Compare March 31, 2021 08:12
@pyhys
Copy link
Collaborator Author

pyhys commented Mar 31, 2021

Rebased on master

@pyhys pyhys force-pushed the improve_documentation_week09 branch from ea968ef to 0f23671 Compare April 1, 2021 06:09
@pyhys
Copy link
Collaborator Author

pyhys commented Apr 1, 2021

Rebased on master

Improve documentation
821f6eb 
Split Codesys page into two pages.

Improve logging
Improve error message display in sample app.
@pyhys pyhys force-pushed the improve_documentation_week09 branch from 0f23671 to 821f6eb Compare April 9, 2021 07:19
@pyhys pyhys closed this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olbjo olbjo olbjo approved these changes

@hefloryd hefloryd Awaiting requested review from hefloryd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyhys @olbjo