Basic adaption of pnet to multiple connections #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyhys
force-pushed
the
move_states_to_ar
branch
from
d9b61d6 to
df2aa5c
Compare
olbjo
approved these changes
Mar 23, 2021
|
|
||
| /* Send application ready */ | ||
| os_event_set (p_appdata->main_events, APP_EVENT_READY_FOR_DATA); | ||
| if (pnet_application_ready (net, arep) != 0) |
There was a problem hiding this comment.
There should be a log message for "pnet_application_ready" call. In default log FATAL configuration I do not think any message will be seen related to to application ready which is an key state transition
"Set application ready"
There was a problem hiding this comment.
This is already in PR #383
Done
src/device/pf_cmdev.c
Outdated
| * true also if only the IOPS is set.*/ | ||
| p_iodata = &p_ar->iocrs[ix].data_desc[iy]; | ||
|
|
||
| /* Users are limited to setting data for a specific subslot. |
There was a problem hiding this comment.
I would go for "Application is" and avoid "users", "you" and references to persons in the log messages and comments.
Also what the checks below actually test is a bit unclear. Are they a workaround or a final solution?
There was a problem hiding this comment.
Updated comment.
Done
pyhys
force-pushed
the
move_states_to_ar
branch
from
df2aa5c to
b505872
Compare
CMSU and CMWRR should be per AR instead of per device. Implement modulediff when another AR owns a submodule. Verify that PPM data have been set for a submodule, regardless of owning AR. The output data frame ID from the PLC should be unique per device, not per AR. Adapt sample application to be able to handle multiple connections. Future work is needed for one input subslot to be able to send data to multiple PLCs. Closes rtlabs-com#131 Closes rtlabs-com#169
pyhys
force-pushed
the
move_states_to_ar
branch
from
b505872 to
fbd08f4
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMSU and CMWRR should be per AR instead of per device.
Implement modulediff when another AR owns a submodule.
Verify that PPM data have been set for a submodule, regardless of owning AR.
The output data frame ID from the PLC should be unique per device, not per AR.
Adapt sample application to be able to handle multiple connections.
Future work is needed for same input subslot to be able to send data to multiple PLCs.
Closes #131
Closes #169