Move plumber to suggests #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, I am realizing that the testing strategy for plumber might not work without plumber in Imports. |
Closed
|
I'm going to close this for now, and we can continue to collect feedback on this change for prioritization. |
|
@jonthegeek I realized that I could move the plumber testing helper into a regular R file in the package, which made this doable after all. Do you want to take a look at this and see if you notice anything that would be a problem for the Lambda use case? |
jonthegeek
reviewed
Oct 27, 2022
|
I'm going to merge it in now then, and we can revisit any problems that come up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136