Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plumber in Suggests? #136

Closed
jonthegeek opened this issue Aug 19, 2022 · 2 comments · Fixed by #140
Closed

plumber in Suggests? #136

jonthegeek opened this issue Aug 19, 2022 · 2 comments · Fixed by #140
Labels
feature a feature request or enhancement

Comments

@jonthegeek
Copy link

I understand if this is a route you don't want to go down, but there are situations where deploying without plumber makes sense, such as on AWS Lambda (see #128). It would be nice to avoid installing extra things in that case, and {plumber} comes with a number of dependencies, including {sodium}, which has a libsodium system requirement (and thus adds another step to the process).

Would you consider moving {plumber} to Suggests for {vetiver}, and only adding it to the vetiver_renv.lock when it makes sense to do so (ie, for almost every deployment path other than Lambda, probably)?

It probably isn't a HUGE issue, but I can imagine getting to a point where we want to shave every little thing out of that container that we can.

@juliasilge
Copy link
Member

Yep, this makes sense. We can move plumber to Suggests and use rlang::check_installed("plumber") in the appropriate places.

@juliasilge juliasilge added the feature a feature request or enhancement label Aug 19, 2022
@juliasilge
Copy link
Member

I did work on this in #140 this week, but it turns out most of the vetiver testing strategy doesn't work without plumber in Imports. (We have a testing strategy where a REST API runs in one session and http calls are made from another session.)

Moving plumber to Suggests would take more work than I initially thought, so let's keep things as is for now but keep this issue open to collect feedback for prioritization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants