Add fill arguments to plotOutput(), imageOutput(), and uiOutput() #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
fill
branch
2 times, most recently
from
c87968d to
89d96ab
Compare
This was referenced Oct 21, 2022
cpsievert
commented
Oct 24, 2022
cpsievert
commented
Oct 24, 2022
cpsievert
commented
Oct 24, 2022
cpsievert
commented
Oct 24, 2022
jcheng5
reviewed
Oct 25, 2022
jcheng5
reviewed
Oct 25, 2022
jcheng5
reviewed
Oct 25, 2022
R/bootstrap.R
Outdated
| @@ -1155,12 +1174,19 @@ dataTableOutput <- function(outputId) { | |||
| #' ) | |||
| #' @export | |||
| htmlOutput <- function(outputId, inline = FALSE, | |||
| container = if (inline) span else div, ...) | |||
| container = if (inline) span else div, fill = FALSE, fillItem = !inline, ...) | |||
There was a problem hiding this comment.
I was envisioning fillItem = FALSE and fill = fillItem. (Or possibly vice versa.) Like, usually the contents of a uiOutput is not going to be a fill item, but if it is (and it matters) then probably the uiOutput's container is a fill container?
There was a problem hiding this comment.
I don't like that you'd have to remember to uiOutput(fillItem = TRUE) to opt-in to fill behavior, yet do fill = FALSE anywhere else to opt-out (which is why I reversed their meaning). Anyway, I think I have a better way forward that I'll implement in the next commit.
jcheng5
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for an explanation of what this PR does
Testing notes
No manual testing needed. With existing tests as well as new ones being added in rstudio/shinycoreci#132, we'll have pretty good coverage on these changes