Add vfill-item CSS class when height isn't specified by user #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the htmlwidget's HTML container gains a
.vfill-item
CSS class whenheight
isNULL
(on the widget instance when statically rendered orshinyWidgetOutput()
when rendered in shiny).The primary motivation for this is so widgets can fill as needed inside
bslib::card_body_fill()
(#452); but more generally, it allows widgets (withheight
ofNULL
) to fill any HTML element with a.vfill-container
class (when used with{bslib}
, since those CSS classes are provided bybs_theme()
), for example:This means, at least for widgets that follow the recommended R binding approach, statically rendered widgets (such as above) won't need any changes to fill by default (within a
vfill-container
). However, the recommend Shiny binding approach ofwill change to
and default sizing should instead be provided through a CSS file, providing something like:
TODO
Update website (and the sigma package?) to reflect the new default sizing approach