parseCssColors(): treat incoming NAs as an invalid color #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n (instead of throwing with an unintelligible error. Closes #161
cpsievert
force-pushed
the
na-css-color
branch
from
7d35370 to
adb0bed
Compare
wch
approved these changes
Dec 2, 2020
wch
reviewed
Dec 2, 2020
wch
reviewed
Dec 2, 2020
R/colors.R
Outdated
| # Note that an empty string is not a valid color, so parsing fails | ||
| # on NA input values, and thus, will be converted back to NA | ||
| # when `mustWork = FALSE` | ||
| if (!(is.character(str) || rlang::is_na(str))) { |
There was a problem hiding this comment.
But what about the cases where it's a vector of (non-character) NAs? As in:
parseCssColors(c(NA, NA))There was a problem hiding this comment.
For some reason I was thinking that'd be a character vector, but I suppose logical makes way more sense!
wch
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161