Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseCssColors errors on missing value #161

Closed
cpsievert opened this issue Apr 14, 2020 · 0 comments · Fixed by #194
Closed

parseCssColors errors on missing value #161

cpsievert opened this issue Apr 14, 2020 · 0 comments · Fixed by #194

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented Apr 14, 2020 •
edited
Loading

It should probably return NA instead

htmltools::parseCssColors(NA)
Error in substring(u, so, so + ml - 1L) : invalid substring arguments
htmltools::parseCssColors(c("red", NA))
Error in substring(u, so, so + ml - 1L) : invalid substring arguments
@cpsievert cpsievert mentioned this issue Dec 2, 2020
Merged
cpsievert added a commit that referenced this issue Dec 2, 2020
@cpsievert
parseCssColors(): treat incoming NAs as an invalid color specificatio…
2f52a8e 
…n (instead of throwing with an unintelligible error. Closes #161
@cpsievert cpsievert mentioned this issue Dec 2, 2020
Merged
cpsievert added a commit that referenced this issue Dec 2, 2020
@cpsievert
parseCssColors(): treat incoming NAs as an invalid color specificatio…
adb0bed 
…n (instead of throwing with an unintelligible error. Closes #161
@wch wch closed this as completed in #194 Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

parseCssColors(): treat incoming NAs as an invalid color rstudio/htmltools
1 participant
@cpsievert