-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate html/svg known_tags from mozilla website information #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things:
So that we don't forget what's going on here, the following would be helpful:
- At the top of the script, add an explanation of what it does.
- In tags.R, right above
known_tags <- ....
, add a comment saying how the content got there.
Have you checked to make sure we haven't lost any tags? It's possible that we had a weird tag that's no longer there.
Other links that are found could be obsolete
✅
Moved the generated tags to a file and gave it a roxygen2-like comment. Now |
I pull in the tags from a CRAN install htmltools. This set is merged with the new set. I also double checked the obsolete tags on SVG and had accidentally included them. They have been removed in 0bc3a62 |
Fixes #84
Should fix alandipert/html2r#4
Automatically pull
Considered pulling information from these websites...
altGlyph