Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate html/svg known_tags from mozilla website information #159

Merged
merged 5 commits into from
Apr 7, 2020

Conversation

schloerke
Copy link
Collaborator

Fixes #84
Should fix alandipert/html2r#4

Automatically pull

Considered pulling information from these websites...

@schloerke schloerke requested review from wch and jcheng5 April 3, 2020 15:25
@schloerke schloerke self-assigned this Apr 3, 2020
Copy link
Collaborator

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things:

So that we don't forget what's going on here, the following would be helpful:

  • At the top of the script, add an explanation of what it does.
  • In tags.R, right above known_tags <- ...., add a comment saying how the content got there.

Have you checked to make sure we haven't lost any tags? It's possible that we had a weird tag that's no longer there.

@schloerke
Copy link
Collaborator Author

@wch

At the top of the script, add an explanation of what it does.

In tags.R, right above known_tags <- ...., add a comment saying how the content got there.

Moved the generated tags to a file and gave it a roxygen2-like comment.

Now tags.R includes known_tags.R.

@schloerke
Copy link
Collaborator Author

@wch

Have you checked to make sure we haven't lost any tags? It's possible that we had a weird tag that's no longer there.

I pull in the tags from a CRAN install htmltools. This set is merged with the new set.

I also double checked the obsolete tags on SVG and had accidentally included them. They have been removed in 0bc3a62

@schloerke schloerke requested a review from wch April 3, 2020 20:41
@wch wch merged commit d40f641 into master Apr 7, 2020
@wch wch deleted the feature/svg_tags branch April 7, 2020 18:55
schloerke added a commit that referenced this pull request Apr 7, 2020
schloerke added a commit that referenced this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG should be excluded Include tags$svg, tags$g, tags$path, etc.
2 participants