Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tags$svg, tags$g, tags$path, etc. #84

Closed
jcheng5 opened this issue Apr 26, 2017 · 5 comments · Fixed by #159
Closed

Include tags$svg, tags$g, tags$path, etc. #84

jcheng5 opened this issue Apr 26, 2017 · 5 comments · Fixed by #159
Assignees

Comments

@jcheng5
Copy link
Member

jcheng5 commented Apr 26, 2017

Also probably should check with latest relevant specs to make sure we're not missing any new tags.

cc @Stophface @timelyportfolio

@wch
Copy link
Collaborator

wch commented Apr 26, 2017

Do we want to include the tags for elements inside the svg?

@jcheng5
Copy link
Member Author

jcheng5 commented Apr 26, 2017

Yep. I'll amend the title.

@jcheng5 jcheng5 changed the title Include tags$svg Include tags$svg, tags$g, tags$path, etc. Apr 26, 2017
@banbh
Copy link

banbh commented Mar 8, 2019

Note that tags in htmltools do not convert "." in "-" (in contrast to css()). I.e., css(a.b=1) is a-b:1; but p(a.b=1) is <p a.b="1"></p>. This may be relevant because many SVG attributes have hyphens (see https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute) as opposed to HTML, where hardly any do.

Might it make sense for all tags to convert "." to "-" (in attributes)? Or perhaps to do so optionally, so that SVG tags could be made to do so?

@ghost
Copy link

ghost commented Mar 30, 2020

Is there any update on this request?

@schloerke schloerke self-assigned this Apr 2, 2020
@schloerke
Copy link
Collaborator

@banbh You are allowed to send in -'ed names.

htmltools::p(`a-b` = 1)
#> <p a-b="1"></p>
htmltools::p("a-b" = 1)
#> <p a-b="1"></p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants