Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should specify perl=TRUE in order to handle emoji strings on Windows #157

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

shrektan
Copy link
Contributor

@shrektan shrektan commented Feb 19, 2020

Closes #156
Closes rstudio/DT#661

@jcheng5 jcheng5 changed the title should specify perf=TRUE in order to handle emoji strings on Windows should specify perl=TRUE in order to handle emoji strings on Windows Feb 19, 2020
@jcheng5 jcheng5 self-requested a review February 19, 2020 15:58
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @shrektan!

@yihui yihui merged commit ce76055 into rstudio:master Feb 20, 2020
@yihui
Copy link
Member

yihui commented Feb 20, 2020

I'm going to merge this PR since this issue has affected multiple DT users. If it's not a good time to merge, please feel free to revert. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants