-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extractPreserveChunks() when string contains emoji unicode on Windows #156
Comments
It appears that the |
cpsievert
added a commit
that referenced
this issue
Jun 8, 2020
cpsievert
added a commit
that referenced
this issue
Jun 9, 2020
* Use fixed=TRUE when finding preserve chunk locations, closes #156 * Store match.length attr directly as `lengths` Co-authored-by: Barret Schloerke <[email protected]> * make sure not to return (instead error) if one marker is present but the other is missing Co-authored-by: Barret Schloerke <[email protected]>
cpsievert
added a commit
that referenced
this issue
Jun 10, 2020
* Use fixed=TRUE when finding preserve chunk locations, closes #156 * Store match.length attr directly as `lengths` Co-authored-by: Barret Schloerke <[email protected]> * make sure not to return (instead error) if one marker is present but the other is missing Co-authored-by: Barret Schloerke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the string contains emoji Unicode like "\U0001F937" on Windows ,
extractPreserveChunks()
returns unexpected results.It leads to an issue that when the user compiles an Rmd file with such Unicode strings on Windows, the htmlwidgets of the HTML output file after the line contains the emoji string, can't be displayed properly, e.g., rstudio/DT#661
The cause of this issue I believe is that
gregexpr(perl = FALSE)
(the default) can't handle such cases properly on Windows (I don't know the reason). By explicitly usingperl = TRUE
will fix this issue.htmltools/R/tags.R
Line 1170 in e07546c
R code to reproduce
The output
The session info
The text was updated successfully, but these errors were encountered: