Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Multi token bridge and NFT bridge #296

Merged
merged 487 commits into from
Mar 16, 2022
Merged

Add Multi token bridge and NFT bridge #296

merged 487 commits into from
Mar 16, 2022

Conversation

pmprete
Copy link
Contributor

@pmprete pmprete commented Jan 9, 2022 •
edited
Loading

NFT Bridge as a WIP
Multi chain bridge allows the bridge to be run against multiple chains like Binance and Ethereum, using the same federators for all of them.
Also we updated the solidity version to 0.8.9
Used typescript for the federator
Used node 16
Update dependencies
Fixed linting using prettier
Fix sonar cloud smells
Refactor the integration tests
Improved logging on federator
Added data dog

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2022

This pull request introduces 4 alerts when merging 79dcc22 into 64a2859 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2022

This pull request introduces 2 alerts when merging 1ae99da into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@coveralls
Copy link

coveralls commented Jan 9, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-1.8%) to 96.48% when pulling 394a95c on nftbridge-rebased into 69219d6 on master.

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2022

This pull request introduces 2 alerts when merging 8c535a6 into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 9, 2022

This pull request introduces 2 alerts when merging 31d5dca into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 27, 2022

This pull request introduces 2 alerts when merging c1799c2 into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 4, 2022

This pull request introduces 2 alerts when merging 3b0a4ff into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 8, 2022

This pull request introduces 2 alerts when merging c54f67c into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 8, 2022

This pull request introduces 2 alerts when merging 50b2aad into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 8, 2022

This pull request introduces 2 alerts when merging ed9952a into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 10, 2022

This pull request introduces 2 alerts when merging ea73218 into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2022

This pull request introduces 2 alerts when merging 069b555 into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 18, 2022

This pull request introduces 2 alerts when merging f06d03e into 64a2859 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2022

This pull request introduces 3 alerts when merging dad0f28 into 64a2859 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

gsoares85 and others added 9 commits March 4, 2022 15:49
@gsoares85
Added assert for when the hexadecimal has more than 34 bytes
b72aa23
Fix bscscan verification on deployment
576944e 
Add a bscscan.key file with the bscscan API key
Set multi key etherscan verification on hardhat.config
Update hardhat-etherscan version
Use getArtifact for MultiSigWallet when already exists as named account but it hasn't been deployed with hardhat
IsRsk needs a network, no the network_id
@gsoares85
Added tests to the hasVoted method
9b9dc24
Flatten and addresses after deploy
12a30d0
Use deployments.get('Bridge') instead of Artifact
4679b98 
We need the address of the deployed bridge not just the ABI
Do the same for the federation
Update the Bsc Testnet addresses on the federator config.
Update From block to use the new contracts as the starting point
@aguschirico
add script to get fee percentage of a network
f49fc52
@aguschirico
script to check whether a transaction was claimed
94eba75
@aguschirico
set setTokenInfoByTokenAddress internal
dda4941
Bump version on package-lock
ed1f879
@pmprete pmprete force-pushed the nftbridge-rebased branch from dad0f28 to dda4941 Compare March 4, 2022 19:50
@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2022

This pull request introduces 3 alerts when merging ed1f879 into 69219d6 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2022

This pull request introduces 3 alerts when merging 7c03d31 into 69219d6 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 7, 2022

This pull request introduces 3 alerts when merging b71382b into 69219d6 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 11, 2022

This pull request introduces 3 alerts when merging 5e1de58 into 69219d6 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

pmprete and others added 2 commits March 14, 2022 13:06
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 108 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@lgtm-com
Copy link

lgtm-com bot commented Mar 14, 2022

This pull request introduces 4 alerts when merging 394a95c into 69219d6 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

aguschirico
aguschirico approved these changes Mar 16, 2022
View reviewed changes
.github/pull_request_template.md
![image](https://user-images.githubusercontent.com/17556614/137998725-3938ce87-87b1-4631-9cff-095935854d6e.png)


7. Run the integration test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference between the step 6 and the step 7? aren't they executing the same tests twice?

@aguschirico aguschirico merged commit 36b64ab into master Mar 16, 2022
@aguschirico aguschirico deleted the nftbridge-rebased branch May 27, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguschirico aguschirico aguschirico approved these changes

@timpaymans timpaymans Awaiting requested review from timpaymans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmprete @coveralls @aguschirico @RafilxTenfen @gsoares85 @augustoIOV