Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed federator error on creating of a new transaction #327

Merged
merged 6 commits into from
Mar 11, 2022

Conversation

gsoares85
Copy link
Collaborator

No description provided.

Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an underlying error, instead of returning null we should fix the actual error

@gsoares85
Copy link
Collaborator Author

I removed all my previously changes in the PR, and added a validation to process the transaction vote and so on only if the transaction it's for that federator side chain.

@gsoares85 gsoares85 requested a review from pmprete March 11, 2022 20:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pmprete pmprete merged commit 5e1de58 into nftbridge-rebased Mar 11, 2022
@pmprete pmprete deleted the feature/TBRE-502-federatorError branch March 11, 2022 20:57
Dominikkq pushed a commit to Dominikkq/tokenbridge that referenced this pull request Jan 19, 2025
…torError

Fixed federator error on creating of a new transaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants