Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onAttach and onDetach to useScrollController and usePageController #436

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Add onAttach and onDetach to useScrollController and usePageController #436

merged 3 commits into from
Jul 22, 2024

Conversation

timcreatedit
Copy link
Contributor

Fixes #420

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f7e62b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rrousselGit
rrousselGit approved these changes Jul 22, 2024
View reviewed changes
Copy link
Owner

@rrousselGit rrousselGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rrousselGit rrousselGit merged commit c5c7dbc into rrousselGit:master Jul 22, 2024
1 check passed
@timcreatedit timcreatedit deleted the feat/on-attach-and-on-detach branch July 22, 2024 10:43
@timcreatedit timcreatedit mentioned this pull request Jul 22, 2024
Merged
sungmin-park pushed a commit to coint-hub/flutter_hooks_add_on_attach that referenced this pull request Jan 6, 2025
@timcreatedit
Add onAttach and onDetach to useScrollController and `usePageCo…
d98fb9a 
…ntroller` (rrousselGit#436)

(cherry picked from commit c5c7dbc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrousselGit rrousselGit rrousselGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onAttach and onDetach is missing on usePageController
2 participants
@timcreatedit @rrousselGit