Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onAttach and onDetach is missing on usePageController #420

Closed
Kinwailo opened this issue Mar 16, 2024 · 2 comments · Fixed by #436
Closed

onAttach and onDetach is missing on usePageController #420

Kinwailo opened this issue Mar 16, 2024 · 2 comments · Fixed by #436
Assignees
@rrousselGit
Labels
enhancement New feature or request

Comments

@Kinwailo
Copy link

Official constructor:
PageController({int initialPage = 0, bool keepPage = true, double viewportFraction = 1.0, ScrollControllerCallback? onAttach, ScrollControllerCallback? onDetach})

Hook usePageController:
PageController usePageController( {int initialPage = 0, bool keepPage = true, double viewportFraction = 1.0, List<Object?>? keys} )
@Kinwailo Kinwailo added enhancement New feature or request needs triage labels Mar 16, 2024
@Spotchi
Copy link

Spotchi commented Jul 4, 2024

+1 here

@rrousselGit
Copy link
Owner

Fancy making a PR?

@timcreatedit timcreatedit mentioned this issue Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrousselGit rrousselGit

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add onAttach and onDetach to useScrollController and usePageController whynotmake-it/flutter_hooks
3 participants
@Spotchi @rrousselGit @Kinwailo