Ptt/fix set param float #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsutherland333
force-pushed
the
PTT/fix_set_param_float
branch
from
401a7ac to
95fe2fb
Compare
bsutherland333
force-pushed
the
PTT/fix_set_param_float
branch
from
95fe2fb to
18e55a3
Compare
|
You had a commit related to your other pull request on this branch, but I fixed that. If everything still looks good to you @avtoku then go ahead and merge. |
bsutherland333
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_param_float in param.cpp was sending the entire set of parameters in response to setting a single parameter instead of just sending back the updated value.