Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove realsense related repos from Foxy, and Rolling #25814

Merged
merged 2 commits into from
Jul 20, 2020
Merged

remove realsense related repos from Foxy, and Rolling #25814

merged 2 commits into from
Jul 20, 2020

Conversation

dirk-thomas
Copy link
Member

All realsense related builds have been failing since they have been added and the maintainers are not responsive. To get rid of the jobs failing on a daily base this PR removes the repos from all active ROS 2 distros.

See #24528 (comment)

@sharronliu @doronhi FYI

@dirk-thomas dirk-thomas self-assigned this Jul 14, 2020
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-dashing-sync-and-patch-release-2020-07-14/15287/5

@ruffsl ruffsl mentioned this pull request Jul 15, 2020
Closed
@nuclearsandwich
Revert changes to Dashing.
eb4ec55 
Rather than removing realsense from Dashing I am attempting to revert to
a working release. See #25837
@nuclearsandwich
Copy link
Member

I reverted the changes to Dashing since I'm attempting to revert to a working release before removing it entirely #25837

nuclearsandwich
nuclearsandwich approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Dashing being handled separately (I made a change and an explanatory comment) I think this makes sense for Foxy and Rolling if no working release was ever available.

@dirk-thomas
Copy link
Member Author

@jacobperron Can you please comment / approve since you are in charge of Foxy.

@doronhi doronhi mentioned this pull request Jul 19, 2020
Closed
@dirk-thomas dirk-thomas changed the title remove realsense related repos from Dashing, Foxy, and Rolling remove realsense related repos from Foxy, and Rolling Jul 20, 2020
@dirk-thomas dirk-thomas merged commit 3c8123b into master Jul 20, 2020
@dirk-thomas dirk-thomas deleted the dirk-thomas/remove-realsense branch July 20, 2020 17:07
@dirk-thomas
Copy link
Member Author

@sharronliu @doronhi Please feel free to open new PRs to re-add the repositories for Foxy and Rolling whenever you have a working version.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/new-packages-for-foxy-fitzroy-2020-07-23/15570/1

@sharronliu sharronliu mentioned this pull request Jul 27, 2020
Merged
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/best-practices-standards-for-ros-2-camera-drivers-request-for-depth-camera-recommendations/15983/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@clalancette clalancette clalancette approved these changes

@cottsay cottsay Awaiting requested review from cottsay

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dirk-thomas @ros-discourse @nuclearsandwich @clalancette @jacobperron