Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librealsense: 2.34.0-1 in 'foxy/distribution.yaml' [bloom] #24528

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

sharronliu
Copy link
Contributor

Increasing version of package(s) in repository librealsense to 2.34.0-1:

@sharronliu sharronliu requested a review from jacobperron as a code owner April 21, 2020 17:42
@tfoote tfoote merged commit 6136abc into ros:master Apr 21, 2020
@sharronliu
Copy link
Contributor Author

sharronliu commented Apr 22, 2020

@tfoote @jacobperron , Let you know for the ROS2 Foxy, still there're some other packages for "ros2_intel_realsense" that I plan to push, which depends on quite some ROS2 core packages (rclcpp, rcl_components, etc.) which are not in the "foxy/distribution.yaml". Could you give some advice when I can proceed with the "ros2_intel_realsense" packages?

@jacobperron
Copy link
Contributor

@sharronliu I'd like to have all core packages released into Foxy before next week.

@sharronliu
Copy link
Contributor Author

@jacobperron , do you get any idea when rclcpp and tf2 will get into foxy?

@jacobperron
Copy link
Contributor

@jacobperron , do you get any idea when rclcpp and tf2 will get into foxy?

They are in Foxy now.

@sharronliu
Copy link
Contributor Author

@jacobperron , do you get any idea when rclcpp and tf2 will get into foxy?

They are in Foxy now.

Great! And my works just delivered #24800, catching the May. 20th due day :)

@dirk-thomas
Copy link
Member

@sharronliu The dev job is failing in camera_calibration (http://build.ros2.org/view/Fdev/job/Rdev__librealsense__ubuntu_focal_amd64/):

CMake Error: install(EXPORT "realsense2Targets" ...) includes target "realsense2" more than once in the export set.
CMake Error: install(EXPORT "realsense2Targets" ...) includes target "realsense2" more than once in the export set.
CMake Error: install(EXPORT "realsense2-glTargets" ...) includes target "realsense2-gl" which requires target "realsense2" that is not in this export set, but in multiple other export sets: lib/cmake/realsense2/realsense2Targets.cmake, lib/cmake/realsense2/realsense2Targets.cmake.
An exported target cannot depend upon another target which is exported multiple times. Consider consolidating the exports of the "realsense2" target to a single export.

The maintainer listed in the package manifest (@dorodnic) should have already received email from Jenkins for the failing builds. I am not sure who is the person currently maintaining this package?

@dirk-thomas
Copy link
Member

@sharronliu @doronhi Friendly ping.

@dirk-thomas
Copy link
Member

@sharronliu @doronhi Friendly ping again. Since this package / repository has failed to build since it was registered (http://build.ros2.org/view/Fbin_uF64/job/Fbin_uF64__librealsense2__ubuntu_focal_amd64__binary/) I will remove it from Foxy and Rolling if I don't hear back.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-07-16/15468/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants