Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mppi_controller] Incorrect constraints in AckermannMotionModel #3579

Closed
alexbuyval opened this issue May 18, 2023 · 3 comments
Closed

[mppi_controller] Incorrect constraints in AckermannMotionModel #3579

alexbuyval opened this issue May 18, 2023 · 3 comments

Comments

@alexbuyval
Copy link
Contributor

I found that the current implementation of constraints for AckermannMotionModel has an incorrect condition here.

auto view = xt::masked_view(wz, xt::fabs(vx) / xt::fabs(wz) > min_turning_r_);

so all generated trajectories collapse to circles (see the attached image).

The correct version should be the following:

auto view = xt::masked_view(wz, xt::fabs(vx) / xt::fabs(wz) < min_turning_r_);

Screenshot from 2023-05-18 10-28-00

@SteveMacenski
Copy link
Member

Good catch - can you submit the PR to resolve since you found the solution?

@alexbuyval
Copy link
Contributor Author

Yes, I'll do

@SteveMacenski
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants