-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Galactic Geochelone to REP 2000 #291
Conversation
Signed-off-by: Scott K Logan <[email protected]>
Signed-off-by: Scott K Logan <[email protected]>
@cottsay @clalancette I provided a detailed feedback on what switching to C++17 currently means in the automotive industry: eclipse-iceoryx/iceoryx#220 (comment). the conclusion is in the last sentence of above comment. I suggest the following: proceed with the switch to C++17 and I'll in the next weeks inquire a) about the willingness of our (automotive) customers to switch to C++17 and b) when Adaptive Autosar Coding Guidelines for C++17 will be available. |
@dejanpan Thanks for the detailed feedback on the switch to C++17. That really helps inform the decision here. Given your feedback, and the fact that we have heard no objections to C++17, we'll go forward with that for now. If it turns out that this is a huge problem, let us know as soon as possible and we'll see what we can do about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to change in here.
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-12-17/18182/1 |
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/macos-support-in-ros-2-galactic-and-beyond/17891/14 |
Signed-off-by: Scott K Logan <[email protected]>
Signed-off-by: Scott K Logan <[email protected]>
Signed-off-by: Scott K Logan <[email protected]>
Signed-off-by: Scott K Logan <[email protected]>
Follow-up to 33f3413 Signed-off-by: Scott K Logan <[email protected]>
Follow-up to f2b5692 Signed-off-by: Scott K Logan <[email protected]>
Follow-up to 6bac4b9 Signed-off-by: Scott K Logan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got one nit and one question inline, but otherwise this looks good to me.
Signed-off-by: Scott K Logan <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Scott K Logan <[email protected]>
The system-provided Python 3 interpreter for RHEL 7 and 8 is version 3.6, so relaxing this minimum requirement to include those platforms. We've been running CI on CentOS 7 for many months, and there don't seem to be any places where we're taking advantage of any features that require Python 3.7. Signed-off-by: Scott K Logan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go ahead and approve, since I think that what we have here is a good start. We can make more updates later. You may want to still consider @jacobperron's comments before merging.
I'm going to make those changes before merging. The chef-based deployment makes it much easier to do than it used to be. |
.. [9] Foxy ROS 2 Repos File | ||
(https://github.com/ros2/ros2/blob/foxy/ros2.repos) | ||
.. [10] Galactic ROS 2 Repos File | ||
(https://github.com/ros2/ros2/blob/master/ros2.repos) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this link should be updated after we branch (circa April).
These are the version numbers present on our CI machines at this time, so it's what we've been developing and testing against. Signed-off-by: Scott K Logan <[email protected]>
Signed-off-by: Scott K Logan <[email protected]>
The first commit is a direct copy from Foxy. To see what's changing, compare the HEAD against that commit.
Quick resources: