Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Noetic to Prerelease website #59

Merged
merged 1 commit into from
May 12, 2020
Merged

Add Noetic to Prerelease website #59

merged 1 commit into from
May 12, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented May 6, 2020

It seems to work locally. It generated a prerelease command for Noetic that appears to be doing the right thing on my machine. The logo image is a placeholder since it hasn't been announced yet.

Modeled after #47 which added Melodic

@sloretz
Copy link
Contributor Author

sloretz commented May 11, 2020

Friendly ping @wjwwood . Are you the prerelease_website maintainer? If so, what does this PR need to get deployed?

@sloretz sloretz requested a review from wjwwood May 11, 2020 23:45
@wjwwood
Copy link
Contributor

wjwwood commented May 12, 2020

I don't consider myself the maintainer of this repository but I was one of the original authors of the current version. Looking at the commit history each ROS boss tended contribute in turn. I will review this for you though.

As for deployment, I don't actually remember. The README describes what is required to set it up, and I assume it is on ros.org which is an OSU server, so maybe just go there and git pull?

@clalancette
Copy link
Contributor

As for deployment, I don't actually remember. The README describes what is required to set it up, and I assume it is on ros.org which is an OSU server, so maybe just go there and git pull?

I think that is the case, but I also don't remember from 2 years ago :(. Maybe @tfoote knows for sure?

@sloretz
Copy link
Contributor Author

sloretz commented May 12, 2020

Thanks @wjwwood ! I'll merge this and search around for how to deploy it

@sloretz sloretz merged commit 15f3109 into master May 12, 2020
@sloretz sloretz deleted the sloretz/noetic branch May 12, 2020 21:32
@sloretz
Copy link
Contributor Author

sloretz commented May 13, 2020

Thanks @wjwwood ! I'll merge this and search around for how to deploy it

Deployed. Process was

  1. Ask @tfoote to add my ssh key
  2. ssh in, git pull in /var/www/prerelease_website
  3. execute ~/reload_httpd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants