Melodic #47
Melodic #47
Conversation
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
| @@ -38,6 +38,13 @@ <h1>Select a ROS distribution to Generate a Prerelease Command</h1> | |||
| Lunar Loggerhead | |||
| </a> | |||
| </div> | |||
| <div class="col-sm-4 melodic-column text-center"> | |||
There was a problem hiding this comment.
I think, unfortunately, you need to update this one and all the other peers to be col-sm-3, since it's supposed to add up to 12 total. See:
There was a problem hiding this comment.
Oh, I see. I mistook the col-sm-4 for the number of boxes across, but it is actually the portion of the length across. Makes sense, I'll fix this.
|
Has the prerelease process been tested on bionic ? (just asking, if it's not we may want to defer making it the preferred platform) |
…ave 4 * 3 length. Signed-off-by: Chris Lalancette <[email protected]>
Good point. I've tested it out on my Xenial box, where it seems to work fine. I don't currently have a Bionic box that can run docker (I've been doing all my bionic work in containers up to this point), but I can see if there is a live USB boot available for Bionic and try it out. |
I got Bionic booting on a machine locally, but I can't get docker to run for some reason. I'm not going to spend too much time on this, so I'll just revert the commit changing the preferred platform for now. |
This reverts commit 14d3a1c.
There was a problem hiding this comment.
lgtm
I got Bionic booting on a machine locally, but I can't get docker to run for some reason. I'm not going to spend too much time on this, so I'll just revert the commit changing the preferred platform for now.
Yeah I think it makes sense to change it only once bionic is out and stable, e.g. we didnt switch the recommended to xenial until a year after the release
|
Great, thanks for the reviews. Merging. |
|
Note (as I don't know if it's on purpose): This hasn't been deployed yet |
Not really on purpose, I didn't get to it yet and I don't know how to do it :). Will bug someone today about getting it deployed. |
|
Deployed now, thanks to @tfoote . |
Add the changes to prerelease website for Melodic. I tested it locally, and it seemed to do the correct thing. The static image here is a placeholder until we get the official logo.