Use 'ros_control style' joint limit files #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use with the |
Bring in-line with other joint limit files.
This allows re-using them with MoveIt and ros_control hw interfaces.
Not joints limits.
'ros_control format' uses different names, so use them.
They were renamed (in c0f71eb), so use the new names.
gavanderhoorn
force-pushed
the
convert_limits_files
branch
from
2fbabbb to
f7af7af
Compare
Renamed in ur_description, so use the new names here as well and pass the right values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per subject.
This converts the joint limit files to 'ros_control style' and updates the xacro macro and
incfiles to be able to use those.Converting these files to this format will allow us to reuse them in MoveIt configurations and for
ros_controllimits.The current values are the ones updated in #513 (so the official ones), but users could of course copy one of these files, update them with preferred limits and then substitute the updated file by passing in the path to it.