Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joint state controller exception starting with 0 time #629

Conversation

01binary
Copy link

@01binary 01binary commented Dec 24, 2023

Fixes #628, crash in joint state controller when given start time less than the publish interval.

Reproduction steps:

  • Build joint state controller from source (the published package does not have the bug yet)
  • Set publish rate less than 100 Hz (i.e. 50 Hz should give you 0.02 seconds publish interval)
  • Start the joint state controller (arbitrary start time will be around 0.01 seconds)
  • Note that if you set the publish rate to 100Hz that would give you 0.01 seconds publish interval, which is not less than start time, so the bug would not be exposed.

Testing

I haven't updated unit tests for joint state controller yet, but the functionality was tested and appears to work:

  • The issue was fixed
  • The problem the bug was trying to solve remains fixed: joint state controller will update immediately on the first update as the author apparently desired, and then wait the publish interval on subsequent updates

@01binary 01binary closed this Mar 5, 2024
@01binary 01binary deleted the bugfix/628-joint-state-controller-fails-zero-time branch March 5, 2024 06:18
@01binary
Copy link
Author

01binary commented Mar 5, 2024

This is now a duplicate of #630 .
I failed to get unit tests passing, and the issue has been solved in the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joint state controller throws exception when start time is less than update rate
1 participant