Integrate JTC switching demo to example_1 #243
Conversation
github-actions
bot
requested review from
bmagyar,
destogl,
homalozoa,
malapatiravi,
mcbed,
progtologist and
rosterloh
|
I realized the same misleading results as described here ros-controls/ros2_control#786 |
| @@ -497,140 +497,3 @@ Available controllers: | |||
|
|
|||
| Moving the robot: | |||
| - see below description of `forward_position_controller` | |||
|
|
|||
There was a problem hiding this comment.
I would also add into the main readme that example of controller switching is under example 1. What do you think?
| @@ -19,6 +19,8 @@ | |||
| <depend>rclcpp</depend> | |||
| <depend>rclcpp_lifecycle</depend> | |||
|
|
|||
| <exec_depend>ros2_controllers_test_nodes</exec_depend> | |||
There was a problem hiding this comment.
Doesn't all packages automatically depend on this?
There was a problem hiding this comment.
what do you mean by automatically?
I would say that lots of dependencies are actually missing here, joint_trajectory_controller etc. Or would you include this in the ros2_control_demo meta package? (which has to be updated as well)
There was a problem hiding this comment.
We should include them in the package they are used. The question is here if not also all other examples depend on this packaged because it is also used there for moving the robot
There was a problem hiding this comment.
yes, these dependencies are missing for all examples. I can add them to all examples once this one is merged into new structure branch?
Co-authored-by: Dr. Denis <[email protected]>
also closes #75 and #220