-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for mimic joints and example with gripper. #107
Support for mimic joints and example with gripper. #107
Conversation
Signed-off-by: Denis Štogl <[email protected]>
36d6e63
to
c99d6f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
can you review linters?
Signed-off-by: Denis Štogl <[email protected]>
@ahcorde this is ready to be merged. There is an issue currently with testing repository for ros2 where ros2_controller are missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment in the launch file
gazebo_ros2_control_demos/launch/gripper_mimic_joint_example.launch.py
Outdated
Show resolved
Hide resolved
@ahcorde just updated! |
you will have to restart CI, something went bad there during environment setup. |
Thank you @destogl ! Looking forward to see this feature in |
Signed-off-by: Denis Štogl <[email protected]>
The PR adds functionality for mimic joints and shows its functionality on a parallel gripper example.
Signed-off-by: Denis Štogl [email protected]
P.S. After resolving everything here, I will port the same functionality to ign_ros2_control.