Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mimic joints and example with gripper. #107

Merged

Conversation

destogl
Copy link
Member

@destogl destogl commented Jan 31, 2022

The PR adds functionality for mimic joints and shows its functionality on a parallel gripper example.

Signed-off-by: Denis Štogl [email protected]

P.S. After resolving everything here, I will port the same functionality to ign_ros2_control.

@destogl destogl force-pushed the feature-add-support-for-mimic-joints branch from 36d6e63 to c99d6f3 Compare January 31, 2022 14:17
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

can you review linters?

Signed-off-by: Denis Štogl <[email protected]>
@destogl
Copy link
Member Author

destogl commented Feb 2, 2022

@ahcorde this is ready to be merged. There is an issue currently with testing repository for ros2 where ros2_controller are missing.

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment in the launch file

@destogl
Copy link
Member Author

destogl commented Feb 2, 2022

@ahcorde just updated!

@destogl
Copy link
Member Author

destogl commented Feb 2, 2022

you will have to restart CI, something went bad there during environment setup.

@ahcorde ahcorde merged commit d18b955 into ros-controls:master Feb 2, 2022
@ahcorde
Copy link
Collaborator

ahcorde commented Feb 2, 2022

Thank you @destogl !

Looking forward to see this feature in ign_ros2_control. Let me know if you don't have time and I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants