Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lintr config for lintr >= 2 #294

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

russHyde
Copy link
Contributor

@russHyde russHyde commented Feb 4, 2021

Prework

Related GitHub issues and pull requests

Summary

Please explain the purpose and scope of your contribution.

The package was set to use CRAN {lintr} (ie, >=v2)

snake_case_linter and camel_case_linter were originally NULL-ed out (deactivated) in the
{targets} .lintr config.

But, these linters were removed from lintr's default-linter set prior to
lintr v2 (so NULLing them in the config doesn't actually do anything).
In fact, the functions are being deprecated.

Hence I removed any mention of these linters from the targets .lintr.

Note that snake_case_linter / camel_case_linter are now implemented as
part of object_name_linter(), but that the latter was already deactivated in
the {targets} .lintr config.

The package was set to use CRAN {lintr} (ie, >=v2)

`snake_case_linter` and `camel_case_linter` were NULL-ed out in the
.lintr config.

But, these linters were removed from lintr's default-linter set prior to
lintr v2 (so NULLing them has no effect).
@wlandau
Copy link
Member

wlandau commented Feb 4, 2021

Thanks, @russHyde.

@wlandau wlandau merged commit 6974b3a into ropensci:main Feb 4, 2021
@wlandau wlandau mentioned this pull request Feb 4, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants