Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.lintr config is for lintr < v2 #295

Closed
7 tasks
russHyde opened this issue Feb 4, 2021 · 1 comment
Closed
7 tasks

.lintr config is for lintr < v2 #295

russHyde opened this issue Feb 4, 2021 · 1 comment

Comments

@russHyde
Copy link
Contributor

russHyde commented Feb 4, 2021

Prework

  • [+] Read and agree to the code of conduct and contributing guidelines.
  • [+] If there is already a relevant issue, whether open or closed, comment on the existing thread instead of posting a new issue.
  • [+] For any problems you identify, post a minimal reproducible example like this one so the maintainer can troubleshoot. A reproducible example is:
    • Runnable: post enough R code and data so any onlooker can create the error on their own computer.
    • Minimal: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
    • Readable: format your code according to the tidyverse style guide.

Description

Please describe the issue.

To help us read any code you include (optional) please try to follow the tidyverse style guide. The style_text() and style_file() functions from the styler package make it easier.

Reproducible example

  • For any problems you identify, post a minimal reproducible example so the maintainer can troubleshoot. A reproducible example is:
    • Runnable: post enough R code and data so any onlooker can create the error on their own computer.
    • Minimal: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
    • Readable: format your code according to the tidyverse style guide.

The linters snake_case_linter and camel_case_linter have been deprecated in {lintr} and were removed from the set of default linters provided by that package prior to lintr v2 (ie, earlier than the current CRAN release of lintr, which targets uses in CI).

In the config, the line snake_case_linter=NULL originally would have prevented newly-named objects that are not 'snake_case' from throwing an object-naming lint.

To permit snake-case vars you would now use object_name_linter("snake_case") in the config, but I noted that object_name_linter has also been NULL-ed out (so, naming issues do not throw lints during targets' CI runs)

Since these linters are now deprecated, they can be removed from your lintr config without any effect.

@wlandau
Copy link
Member

wlandau commented Feb 4, 2021

Fixed in #294. Thanks for the PR.

@wlandau wlandau closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants