Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cling::ForwardDeclPrinter: skip expr tmplt args #7389

Merged
merged 5 commits into from
Mar 6, 2021
Merged

cling::ForwardDeclPrinter: skip expr tmplt args #7389

merged 5 commits into from
Mar 6, 2021

Conversation

Axel-Naumann
Copy link
Member

@Axel-Naumann Axel-Naumann commented Mar 5, 2021 •
edited
Loading

Should repair but not close cms-sw/cmsdist#6690 (comment)

@Axel-Naumann Axel-Naumann added this to the 6.24/00 milestone Mar 5, 2021
@Axel-Naumann Axel-Naumann self-assigned this Mar 5, 2021
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann linked an issue Mar 5, 2021 that may be closed by this pull request
Must not forward declare template specialization with enumerator as template arg #7390
Closed
@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@mrodozov
Copy link

mrodozov commented Mar 5, 2021

I'm stealing this to test it :)

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@davidlange6 davidlange6 mentioned this pull request Mar 6, 2021
Closed
@Axel-Naumann Axel-Naumann merged commit fc91dc6 into root-project:master Mar 6, 2021
@Axel-Naumann Axel-Naumann deleted the cling-FwdDeclPrint-TemplateArgExpr branch March 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal approved these changes

@vgvassilev vgvassilev Awaiting requested review from vgvassilev

Assignees

@Axel-Naumann Axel-Naumann

Labels
None yet
Projects
None yet
Milestone
6.24/00
Development

Successfully merging this pull request may close these issues.

Must not forward declare template specialization with enumerator as template arg
4 participants
@Axel-Naumann @phsft-bot @mrodozov @pcanal