Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update root master #6690

Closed
wants to merge 3 commits into from
Closed

Update root master #6690

wants to merge 3 commits into from

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Mar 1, 2021

TF1 version now changes to 12, see root-project/root#7274

@mrodozov
Update root master
3638b97 
TF1 version now changes to 12, see root-project/root#7274
@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 1, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_3_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e32a3/13181/summary.html
COMMIT: 3638b97
CMSSW: CMSSW_11_3_ROOT6_X_2021-02-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6690/13181/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-02-28-2300/src/RecoRomanPot/RecoFP420/plugins/TrackerizerFP420.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_ROOT6_X_2021-02-28-2300/src/RecoRomanPot/RecoFP420/plugins/module.cc
>> Building  edm plugin tmp/slc7_amd64_gcc900/src/RecoRomanPot/RecoFP420/plugins/RecoRomanPotRecoFP420Plugins/libRecoRomanPotRecoFP420Plugins.so
Leaving library rule at src/RecoRomanPot/RecoFP420/plugins
@@@@ Running edmWriteConfigs for RecoRomanPotRecoFP420Plugins
DataFormatsProvenance_xr dictionary forward declarations' payload:56:28: error: use of undeclared identifier 'ParameterSetType'
namespace edm{typedef Hash ParameterSetID __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/ParameterSetID.h")))  __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/BranchDescription.h"))) ;}
                           ^
DataFormatsProvenance_xr dictionary forward declarations' payload:57:28: error: use of undeclared identifier 'ParentageType'
namespace edm{typedef Hash ParentageID __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/ParentageID.h")))  __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/BranchDescription.h"))) ;}
                           ^

@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 2, 2021 •
edited
Loading

@davidlange6 could this have anything to do with your latest work in cms-sw/cmssw#33014 ?
I'm asking before dig in

@davidlange6
Copy link
Contributor

no. But it looks related to errors I posted to the core Mattermost last week (the Hash). Perhaps @Axel-Naumann is already looking at something similar
(https://github.com/cms-sw/cmssw/blob/master/DataFormats/Provenance/interface/HashedTypes.h)

Leaving library rule at src/RecoRomanPot/RecoFP420/plugins
@@@@ Running edmWriteConfigs for RecoRomanPotRecoFP420Plugins
DataFormatsProvenance_xr dictionary forward declarations' payload:56:28: error: use of undeclared identifier 'ParameterSetType'
namespace edm{typedef Hash<ParameterSetType> ParameterSetID __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/ParameterSetID.h")))  __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/BranchDescription.h"))) ;}
                           ^
DataFormatsProvenance_xr dictionary forward declarations' payload:57:28: error: use of undeclared identifier 'ParentageType'
namespace edm{typedef Hash<ParentageType> ParentageID __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/ParentageID.h")))  __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/BranchDescription.h"))) ;}
                           ^
DataFormatsProvenance_xr dictionary forward declarations' payload:58:28: error: use of undeclared identifier 'ProcessHistoryType'
namespace edm{typedef Hash<ProcessHistoryType> ProcessHistoryID __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/ProcessHistoryID.h")))  __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/BranchDescription.h"))) ;}
                           ^
DataFormatsProvenance_xr dictionary forward declarations' payload:59:28: error: use of undeclared identifier 'ProcessConfigurationType'
namespace edm{typedef Hash<ProcessConfigurationType> ProcessConfigurationID __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/ProcessConfigurationID.h")))  __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/BranchDescription.h"))) ;}
                           ^
DataFormatsProvenance_xr dictionary forward declarations' payload:60:28: error: use of undeclared identifier 'EntryDescriptionType'
namespace edm{typedef Hash<EntryDescriptionType> EntryDescriptionID __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/EntryDescriptionID.h")))  __attribute__((annotate("$clingAutoload$DataFormats/Provenance/interface/EventEntryInfo.h"))) ;}
                           ^
DataFormatsProvenance_xr dictionary forward declarations' payload:61:28: error: use of undeclared identifier 'ModuleDescriptionType'
namespace edm{typedef Hash<ModuleDescriptionType> ModuleDescriptionID;}
                           ^
edmWriteConfigs: /build/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.23.01-d0520f36b3c94cb8dcdd42bbef260b92/root-6.23.01/interpreter/cling/lib/Interpreter/Transaction.cpp:136: void cling::Transaction::append(cling::Transaction::DelayCallInfo): Assertion `getState() == kCollecting && "Cannot append declarations in current state."' failed.

@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 2, 2021

Hm, so it's not ROOT (root builds) but it's ROOT (comes from root). I'll check it :)

@Axel-Naumann
Copy link

Any chance that that I can see the DataFormatsProvenance_xr dictionary as generated?

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 2, 2021 via email

@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 2, 2021

So we have the second:
https://reviews.llvm.org/D36368?id=109963
of four updates but since then this part of llvm has changed and now the context of this last change is very different
Anyway, I'll try to get the last update later and see if it helps

@Axel-Naumann
Copy link

In my reproducer I get the following warnings:

Warning: Forward declarations of templates with enums as template parameters. The responsible class is: NonTypeTemplateParmDecl 0x55d9c8152fb0 </home/axel/build/tmp/CMS-typedef-template-args-fwd-decl/cl1.h:9:11, col:16> col:16 'cl1::Enum' depth 0 index 0 E

Warning: Problems with arguments for forward declaration of class Template

Can you confirm that you get those when generating the relevant dictionaries?

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 4, 2021 •
edited
Loading

What I was doing was try build the latest commits on this LLVM issue and then build cmssw so - not yet :/ Without much success
Because this is failing with the same LLVM commit (regardless where we take it from) I don't expect it will work as it is unless we change something so I was trying to get this new commits from the issue and see if this helps - before going and try to figure it what this code actually does (last resort to do it without thinking :D )

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 4, 2021

I figured it I'm searching the logs :)

@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 4, 2021 •
edited
Loading

running
grep -r "Forward declarations" jenkins-artifacts/pull-request-integration/PR-1e32a3/13181/
doesn't return anything. how did you get this warning Axel ? I'll run the build anyway to check but I think all warnings should be in the logs already in
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e32a3/13181/
You can also see
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e32a3/13181/build-logs/
which is compilation warnings (from cmssw)

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@Axel-Naumann
Copy link

Axel-Naumann commented Mar 4, 2021 via email

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@Axel-Naumann
Copy link

https://github.com/cms-sw/cmssw-config/blob/ef9d787cad2b4af040256fb0e14bbe7540a55351/SCRAM/GMake/Makefile.lcgdict#L34 looks good to me. I'll ask our CMSSW experts for help!

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 4, 2021 via email

@pcanal
Copy link

pcanal commented Mar 4, 2021

Where can I find this build (and/or how can I reproduce it)?

@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 4, 2021 •
edited
Loading

You can use this for reproducing the build
/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6690/13181/install.sh
use an of the cmsdev machines, once it's setup run
scram b -j 16
if you mean the build by David

@pcanal
Copy link

pcanal commented Mar 5, 2021

@mrodozov thanks.

@Axel-Naumann
Copy link

Thanks everyone! Update: I can now reproduce it, it being the real thing. (No, there's no warning.) Debugging...

This was referenced Mar 5, 2021
Merged
Closed
Axel-Naumann added a commit to Axel-Naumann/roottest that referenced this pull request Mar 5, 2021
@Axel-Naumann
Add test for CMS fwd decl enumerator as template arg:
568ae3a 
See cms-sw/cmsdist#6690 (comment)
Tests root-project/root#7390
@Axel-Naumann Axel-Naumann mentioned this pull request Mar 5, 2021
Merged
@davidlange6
Copy link
Contributor

hi @Axel-Naumann , all - I tested your PR (root-project/root#7389) with cmssw - everything builds and at least one simple workflow that I tried runs. So this looks ready to try in our IB this week. Thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2021

Pull request #6690 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2021

Pull request #6690 was updated.

@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 6, 2021

please test
lets try it

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e32a3/13313/summary.html
COMMIT: d5cd092
CMSSW: CMSSW_11_3_ROOT6_X_2021-03-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6690/13313/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1e32a3/34634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1e32a3/34834.999_TTbar_14TeV+2026D76PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2849195
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2849172
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files

Axel-Naumann added a commit to root-project/roottest that referenced this pull request Mar 7, 2021
@Axel-Naumann
Add test for CMS fwd decl enumerator as template arg:
ac70789 
See cms-sw/cmsdist#6690 (comment)
Tests root-project/root#7390
@mrodozov
Copy link
Contributor Author

mrodozov commented Mar 7, 2021

closing this, see #6704

@mrodozov mrodozov closed this Mar 7, 2021
@mrodozov mrodozov deleted the mrodozov-patch-1 branch March 7, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrodozov @cmsbuild @davidlange6 @Axel-Naumann @pcanal