-
Notifications
You must be signed in to change notification settings - Fork 657
Interactive CLI and init command fixes #164
Conversation
cli-reporter: In select, when pressing escape, kill the process cli-reporter: In select, when we kill the process, also output a warning message local init command: Add support for tests component local init command: Error when a project already exists in the cwd
I'll close #161 because this fixes the issue but I have one small nit, could you put the warning on a new line? |
I ran the
This seems to be a bug, I could fix it for now with this, but the result does not look like yours (the link is not clickable): reporter.error(
`<filelink emphasis target="${configPath.join()}" /> file already exists`,
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filelink
tag is not properly closed on windows, the script then crashes when the rome.json
already exists.
const configPath = req.client.flags.cwd.append('rome.json'); | ||
if (await exists(configPath)) { | ||
reporter.error( | ||
`<filelink target="${configPath.join()}" emphasis>rome.json</emphasis> file already exists`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`<filelink target="${configPath.join()}" emphasis>rome.json</emphasis> file already exists`, | |
`<filelink emphasis target="${configPath.join()}" /> file already exists`, |
Oops, I actually fixed that bug forgot to commit it. |
Resolves #161 and #162