Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

added docs for init and lint commands #156

Merged
merged 10 commits into from
Apr 24, 2020

Conversation

MareikeTaeubner
Copy link

@MareikeTaeubner MareikeTaeubner commented Mar 8, 2020

Added 'How to use' documentation for init and lint to the website.

Contributes to #105

I'm not a native English speaker, please correct me, if something sounds wrong ^^"

Copy link
Contributor

@rzig rzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - just a few writing tweaks.

$ rome init
```

Following this `rome` will ask you, whether you want to use the default setup or customize your project further.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the comma here

Comment on lines 30 to 32

If you choose `yes`, it will create a default configuration file `rome.json` that looks like this:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever you're talking about something Rome does at the beginning of a new section, use rome, not "it"
Also, you can surround rome.json with commas

? Project name:
```

After this you have again a choice whether you want to enable linting and formatting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove again
Add "of" between "a choice" and "whether"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add instructions on how to navigate up and down between options since the CLI does not provide that information


### `lint`

The `lint` command lets romes linter check your project files for problems. If no arguments are given, the entire project will be included.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can simplify this:
The lint command checks your project files for code problems, such as unused variables. If no arguments are given, the entire project will be included.


#### Interpreting the result

If everything was fine, you'll get the a result like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to be specific, so instead of "everything was fine," say something like "If Rome did not detect any problems"

website/docs/introduction/commands.md Show resolved Hide resolved
ℹ Add "type": "module" to your package.json
```

Those messages contain the following sections:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use these instead of those

description: Detailed description of the available commands.
---

## Commands
Copy link
Contributor

@rzig rzig Mar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docusaurus will put a Commands header for you so you don't need this. As a result, all of the level three headers should be level two, and all the level four headers should be level three.

@rzig
Copy link
Contributor

rzig commented Mar 8, 2020

Not sure if we want to have a separate sidebar category for commands, with a page for each command - I think this is probably fine for now, we can always break it up later.

@MareikeTaeubner
Copy link
Author

@rzig I included your suggestions into the documentation. Thank you very much :)

@sebmck
Copy link
Contributor

sebmck commented Mar 10, 2020

Nice! This is great! The init command output will change a bit due to #164. Happy to merge if you can change the docs to the new format.

@zinyando
Copy link
Contributor

@MareikeTaeubner can you test the commands on the latest master and see if there are any differences in output and update your PR so that it gets merged. Otherwise, your PR looks great!

@MareikeTaeubner
Copy link
Author

I removed the test section in the output of the init command, since it isn't printed anymore and is also not included in the rome.json anymore. The other stuff looked quite the same for me.

@sebmck
Copy link
Contributor

sebmck commented Apr 24, 2020

Thank you! Sorry for the delay in merging. Would love to have you involved in the Discord, we have the channel #contributors-website for website/docs discussion.

@sebmck sebmck merged commit 7f19b18 into rome:master Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants