Complete rewrite from scratch is here \o/ #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lib has been entirely rewritten in order to have the source code in TypeScript and leveraging the "tsdx" package for bundling, testing and linting. BREAKING CHANGE: As part of the rewrite, the global exports are gone. Please use CommonJS or ESM style imports as specified in the README. fixes #55 closes #57
If NODE_ENV is 'production' then the first part of the evaluation short-circuits the conditional passed into handleError, ensuring that in production environments the check for whether the error has to be thrown at all is not resolved, ultimately increasing performance. Furthermore if NODE_ENV is undefined or an empty string it is also assumed to be production, to provide for those who do not use a common framework such as create-react-app, NextJS or Gatsby.
Now matches other common invariant functions
Until enzyme updates to React 17
covered by all-contributors and listed in README
cfanoulis
reviewed
Oct 21, 2020
|
Note: Size Limit Analysis CI is failing because there is no size-limit on master branch yet. Ignore it for now. |
This was referenced Oct 21, 2020
cfanoulis
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the lib from the ground up. Using the original code as a basis while completely reimplementing everything.
fixes #55 closes #57
closes #60 closes #62 closes #49