Allow non-booleans in the condition prop as a convenience
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow for users to pass non-booleans in and evaluate simply for truthiness.
hcharley
changed the title
condition prop as a conveniencecondition prop as a convenience
favna
added a commit
that referenced
this pull request
Oct 19, 2020
The lib has been entirely rewritten in order to have the source code in TypeScript and leveraging the "tsdx" package for bundling, testing and linting. BREAKING CHANGE: As part of the rewrite, the global exports are gone. Please use CommonJS or ESM style imports as specified in the README. fixes #55 closes #57
favna
added a commit
that referenced
this pull request
Oct 21, 2020
The lib has been entirely rewritten in order to have the source code in TypeScript and leveraging the "tsdx" package for bundling, testing and linting. BREAKING CHANGE: As part of the rewrite, the global exports are gone. Please use CommonJS or ESM style imports as specified in the README. fixes #55 closes #57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #55
I think I probably also have to update the
propTypesto prevent development warnings, but I'm a bit rusty on that, so I will have to figure that out later. Figure I'd open this in the meantime to get comments on the type definitions piece.