This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
WIP: Use user supplied TypeScript installation #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stakx
reviewed
Jul 28, 2018
| }, | ||
| "peerDependencies": { | ||
| "tslib": "^1.9.0", | ||
| "typescript": "1.x || 2.x" |
There was a problem hiding this comment.
Perhaps I am misunderstanding, but based on tslib's installation instructions (reproduced below) I believe that "tslib": "^1.9.0" would require "typescript": "^2.3.3".
# TypeScript 2.3.3 or later npm install --save tslib # TypeScript 2.3.2 or earlier npm install --save [email protected]
I think it would be fair by now to just require "typescript": "^2.3.3".
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of shipping our own version of TypeScript we use the one supplied by the user via
peerDependencies. I obviously need to break the commit apart and make the history a bit cleaner, but functionality-wise everything works as expected.Changes:
es2015targetObject.assignpolyfillprepublish->prepublishOnly