This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Add __generator helper #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same question as before: tests? |
|
Unfortunately the same answer would apply - they depend on TypeScript 2 :) |
|
Ping here - it would be really nice to get Rollup itself built using async/await and this is currently blocking that. Let me know what I can do here, short of running a full TypeScript 2 upgrade? |
|
@guybedford I made a PR which uses the users typescript installation and the official helpers. See #117 . |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow the Rollup codebase to start using async/await syntax which would be super useful.
This is a complete duplicate of #72.
This was closed to work on a larger 2.0 rewrite which seems to be unfortunately stalled. Incremental progress should always win though.