-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript): support 4.7 nodenext #1194
feat(typescript): support 4.7 nodenext #1194
Conversation
OK I finally got around to deep dive into this issue and iron out the details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the time you put into this. We'll need one more review to merge this, I'll tag a few folks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very promising. Some questions about globbing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any update about this PR? |
I could fix the conflicts but I'll need someone to merge it 😅 |
@perrin4869 please do, then ping me directly if you don't see action within 24 hours. |
Done! 😄 |
Rollup Plugin Name:
typescript
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
Add support for the new
module: nodenext/node16
typescript options in4.7
. This is breaking because it will now requiretypescript >= 4.7
. I tested that this works in my environment viapatch-package
, but there are broken tests, etc. If one of the maintainers can provide pointers towards getting this ready I will be highly grateful!