Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master to develop after 1.14.0 #927

Merged
merged 76 commits into from
May 25, 2022
Merged

Conversation

minump
Copy link
Collaborator

@minump minump commented May 19, 2022

Description

Release branch to be merged to develop.
Master to develop merge after Release 1.14.0

Fixes #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@minump minump self-assigned this May 19, 2022
@sandeep-ps
Copy link
Collaborator

Made one suggestion. The rest looks good to me. Thanks.

changed to dev urls

Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
@sandeep-ps sandeep-ps self-requested a review May 25, 2022 15:03
@sandeep-ps
Copy link
Collaborator

I'm merging this as there are other PRs waiting for this to be merged.

@sandeep-ps sandeep-ps merged commit 7b85eec into develop May 25, 2022
@sandeep-ps sandeep-ps deleted the master-to-develop-after-1.14.0 branch May 25, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants