Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/1.13.0 #894

Merged
merged 18 commits into from
Apr 4, 2022
Merged

Release/1.13.0 #894

merged 18 commits into from
Apr 4, 2022

Conversation

sandeep-ps
Copy link
Collaborator

@sandeep-ps sandeep-ps commented Apr 4, 2022 •
edited
Loading

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Fixes #892

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

sandeep-ps and others added 16 commits December 16, 2021 14:59
@sandeep-ps @bingzhang @ywkim312
Merge to develop after 1.12.1 (#848)
029cc54 
* Update CHANGELOG.md

* Update version numbers in the OpenAPI documents.

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update version number in YAML file.

* Point to production health and talent chooser API documentation in production.

* Update CHANGELOG.

* Update version number in OpenAPI spec files.

* Update Building Block URL in Api Doc Dockerfile.

* Minor update to CHANGELOG.

* Fix Auth library dependencies versions to avoid breaking changes.

* Update Events Building Block Dockerfile.

* Update App Config Dockerfile.

* Update Authentication Building Block Dockerfile.

* Update Profile Building Block Dockerfile.

* Update Contributions Building Block Dockerfile and requirements.

* Update Contributions Catalog Dockerfile and requirements.

* Update Logging Building Block Dockerfile.

* Update version numbers in API specs.

* Update CHANGELOG.

* Update CHANGELOG.md

* Update version number.

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update version numbers in OpenAPI specification.

* turn off group authentication on image get endpoint

* turn off group authentication on image get endpoint

* Update Events Building Block logs and related configuration.

* Update CHANGELOG.

* Added more information to logs

* changed the log's building block name

* updated to use longDescription

* updated changelog

* Update CHANGELOG and verson numbers.

* Update API Doc Dockerfile.

* Fix CHANGELOG.

* Fix CHANGELOG.

* Update version numbers in SECURITY.md

* Fix merge conflicts.

* Update CHANGELOG.md

* Update CHANGELOG.

* Update Dockerfile.

* Update version number in API spec files.

* Updater version in SECURITY.md

* Update Dockerfile.

Co-authored-by: Bing Zhang <[email protected]>
Co-authored-by: YONG WOOK KIM <[email protected]>
@ywkim312 @sandeep-ps
removed unused methods (#838)
09ceb4d 
* removed unused methods

* modified changelog

Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
@ywkim312 @sandeep-ps
added error message for 500 to logger (#841)
9892117 
* added error message for 500 to logger

* made error message as constant

* modified import

* modified import

* removed exception statement being printed out

Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
@ywkim312
added secure string comparison) (#851)
65afd33 
* added secure string comparison

* reverted unnecessary comparison
@ywkim312 @sandeep-ps
847 fix event bb get delete for admin app (#849)
d23c095 
* added GET for all_group_events

* added delete option

* fixed delete method

* added line to deal with comma separated file

* updated changelog

* removed ALL_EVENTS variables from event service's group auth

* removed all_event related code

* modified changelog

* modified query param's format query

* change comment

* changed comment

Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
@minump @ywkim312 @sandeep-ps
814 create source repo url required conditionally (#820)
c79a070 
* Edits for /ok endpoint

* Added ok endpoint to CHANGELOG

* TODO in contribute html

* updated sourceurl field to hidden when required

* updated source url field to show and hide onclick radio button

* added source repo url field UI changes

* deleted unwanted comments

* added last line to changelog

* change position of sourceurl field

* added source repo url

* updated capability with sourceRepoUrl

* added sourceRepoUrl field

* added source repo url in the post

* changed onclick show hide function sourceRepoUrl

* fixed typo

* added check if talent name field exists

* added display of sourerepourl in edit page

* updating default value for isOpenSource

* changed value of isopensource

* added explicit true condition for isopensource

* fixed radio button check in contribute edit

* update to sourceRepoUrl field in capabilities

* added explicit if statement

Co-authored-by: YONG WOOK KIM <[email protected]>
Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
@ywkim312 @sandeep-ps
Reviewer Page (#819)
115eb33 
* initial commit

* modified changelog

* added review in contribution bb

* saving purpose

* working version

* fixed based on comment

* modified comments

* removed review flag

* fixed url redirect in review page

* redirect page after submitting review

* modified based on comment

* added reset button's style

* changed reset button color

Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
@sandeep-ps
726 update codeowners file (#862)
d443baf 
* Update CODEOWNERS

Change assignment for Catalog, App Config, and Authentication BB.

* Update CODEOWNERS

Remove extra spaces.

* Update CHANGELOG.md
@sandeep-ps
846 update events bb api doc (#852)
25c2b05 
* Fix imageURL field name in Events BB Api Doc.

* Update CHANGELOG.md
@minump
864 add email reviewer (#865)
d219a03 
* Edits for /ok endpoint

* Added ok endpoint to CHANGELOG

* updated yaml to include email

* added reviewer email

* resolved merge conflicts

* updated changelog
@bingzhang
query by createdBy (#875)
8e09c13 
* query by createdBy

* udates

* updates

* updates
@bingzhang @sandeep-ps
add tags (#876)
7b46628 
* add tags

* Update tags.json

* Update tags.json

* Update tags.json

* Update tags.json

* Fixed intramural tag position and capitalization.

Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
@minump @sandeep-ps
857 add talent to existing contribution (#866)
336a2d7 
* Edits for /ok endpoint

* Added ok endpoint to CHANGELOG

* updated post.talent in contribute page

* updated changelog

Co-authored-by: Sandeep Puthanveetil Satheesan <[email protected]>
@sandeep-ps
Fix build error in Events BB. (#885)
26238f2
@sandeep-ps
Update CHANGELOG.
1d00bab
@sandeep-ps
Update Events BB version number.
a136690
@sandeep-ps sandeep-ps self-assigned this Apr 4, 2022
@sandeep-ps sandeep-ps linked an issue Apr 4, 2022 that may be closed by this pull request
[TASK] Release 1.13.0 #892
Closed
@sandeep-ps sandeep-ps marked this pull request as ready for review April 4, 2022 16:29
@sandeep-ps sandeep-ps requested a review from minump April 4, 2022 16:29
minump
minump approved these changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@minump minump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested events BB. approved.

@sandeep-ps
Copy link
Collaborator Author

Thanks, @ywkim312 and @minump for the quick review.

Hi, @bingzhang, Do you have any feedback on this PR?

@sandeep-ps
Copy link
Collaborator Author

Thanks, Bing. I will merge this then.

@sandeep-ps sandeep-ps merged commit 7c09b3d into master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minump minump minump approved these changes

@ywkim312 ywkim312 ywkim312 approved these changes

@bingzhang bingzhang bingzhang approved these changes

Assignees

@sandeep-ps sandeep-ps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Release 1.13.0
4 participants
@sandeep-ps @bingzhang @ywkim312 @minump