Completion for pkg path inside strings #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdp
approved these changes
Feb 26, 2021
TwitchBronBron
commented
Feb 26, 2021
elsassph
reviewed
Feb 27, 2021
| const [, openingQuote, fileProtocol] = match; | ||
| //include every absolute file path from this scope | ||
| for (const file of scope.getAllFiles()) { | ||
| const pkgPath = `${fileProtocol}:/${file.pkgPath.replace(/\\/g, '/')}`; |
There was a problem hiding this comment.
pkgPath is supposed to be normalised already no? Seems like a waste.
There was a problem hiding this comment.
Until #329 merges, pkgPath uses windows separators on windows, and unix separators everywhere else. So this is absolutely necessary right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes:
pkg:orlibpkg:.I couldn't get this to auto-show the completions while typing. so you have to manually activate the intellisense menu using a keyboard shortcut or the command pallet.
fixes #333
fixes #228